TINY-11909: Add support for readonly mode

[lorenzo-pomili]

Related ticket: TINY-11909

added support for readonly mode and now disabled prop uses the editor disable

[michalnieruchalski-tiugo]

(question)
Let's say the customer is using TinyMCE 7.0 with this integration. They set the editor to be disabled disabled=true. (This will cause the editor to initially be in readonly mode) They've decided to bump the version of the integration so that it'll include this change.

Will the editor be in readonly mode?

I think it won't. Because initially editor's init method has

readonly: false,
disabled: true

but the disabled property is ignored by TinyMCE 7.0.

---

We can't use the isDisabledOptionSupported method without the editor instance, so it'll be tricky to set the init object correctly. (That's why I was forced to compare the versions in my PR :( )

[lorenzo-pomili]

(question) Let's say the customer is using TinyMCE 7.0 with this integration. They set the editor to be disabled disabled=true. (This will cause the editor to initially be in readonly mode) They've decided to bump the version of the integration so that it'll include this change.

Will the editor be in readonly mode?

I think it won't. Because initially editor's init method has

readonly: false,
disabled: true

but the disabled property is ignored by TinyMCE 7.0.

We can't use the isDisabledOptionSupported method without the editor instance, so it'll be tricky to set the init object correctly. (That's why I was forced to compare the versions in my PR :( )

don't we would have the same behavior using the version check? if the disabled prop will not be upgraded they will get a different behavior

[michalnieruchalski-tiugo]

(question) Let's say the customer is using TinyMCE 7.0 with this integration. They set the editor to be disabled disabled=true. (This will cause the editor to initially be in readonly mode) They've decided to bump the version of the integration so that it'll include this change.
Will the editor be in readonly mode?
I think it won't. Because initially editor's init method has

readonly: false,
disabled: true

but the disabled property is ignored by TinyMCE 7.0.
We can't use the isDisabledOptionSupported method without the editor instance, so it'll be tricky to set the init object correctly. (That's why I was forced to compare the versions in my PR :( )

don't we would have the same behavior using the version check? if the disabled prop will not be upgraded they will get a different behavior

Yes it would. Therefore we should set the init object correctly

{
...(isDisabledOptionSupported() ? { disabled: disabled, readonly: readonly } : { readonly: disabled }  )
}

[lorenzo-pomili]

(question) Let's say the customer is using TinyMCE 7.0 with this integration. They set the editor to be disabled disabled=true. (This will cause the editor to initially be in readonly mode) They've decided to bump the version of the integration so that it'll include this change.
Will the editor be in readonly mode?
I think it won't. Because initially editor's init method has

readonly: false,
disabled: true

but the disabled property is ignored by TinyMCE 7.0.
We can't use the isDisabledOptionSupported method without the editor instance, so it'll be tricky to set the init object correctly. (That's why I was forced to compare the versions in my PR :( )

don't we would have the same behavior using the version check? if the disabled prop will not be upgraded they will get a different behavior

Yes it would. Therefore we should set the init object correctly

{
...(isDisabledOptionSupported() ? { disabled: disabled, readonly: readonly } : { readonly: disabled }  )
}

isn't the same? I mean if someone with disable: true will update to a new version they will get a isDisabledOptionSupported() true and { disabled: true, readonly: false } the only difference is that if they use readonly with an old version of the editor, which is a pretty unlike scenario

[spocke]

I think this check needs to be different after talking to @michalnieruchalski-tiugo since we want to feed readonly or disabled in at init time as well and then we don't have the editor instance.

[spocke]

If they use disabled=true on a old editor version then it wouldn't be disabled since that option didn't exist prior to 7.6.

[lorenzo-pomili]

@spocke, @michalnieruchalski-tiugo I fixed it, with a check in the setup, let me know what do you think about it

[tiny-ben-tran]

Bumping the minor version should fix the CI failure