Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Analytics #125

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Improve Analytics #125

merged 4 commits into from
Jan 24, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 23, 2025

Closes TOOL-3145


PR-Codex overview

This PR focuses on enhancing the Thirdweb wallet functionality by introducing new properties, improving connection tracking, and updating wallet creation methods. It also incorporates the Moq package for testing purposes.

Detailed summary

  • Added WalletId property to InAppWallet, SmartWallet, PrivateKeyWallet, and EcosystemWallet.
  • Introduced TrackConnection and TrackTransaction methods in Utils.
  • Updated wallet creation methods to track connections.
  • Changed _wallet to Wallet in ThirdwebTransaction for better accessibility.
  • Included Moq package in project dependencies.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 23, 2025

@0xFirekeeper 0xFirekeeper self-assigned this Jan 23, 2025
@0xFirekeeper 0xFirekeeper added the enhancement New feature or request label Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (5348711) to head (b4f978e).

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Utils/Utils.cs 85.41% 6 Missing and 1 partial ⚠️
...rdweb.Wallets/PrivateKeyWallet/PrivateKeyWallet.cs 70.00% 3 Missing ⚠️
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   76.64%   76.84%   +0.20%     
==========================================
  Files          28       28              
  Lines        4804     4863      +59     
  Branches      665      666       +1     
==========================================
+ Hits         3682     3737      +55     
- Misses        948      953       +5     
+ Partials      174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit a6afc39 into main Jan 24, 2025
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/improved-analytics branch January 24, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants