Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding Session ID for Guest mode #124

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 17, 2025

Closes TOOL-3133


PR-Codex overview

This PR introduces additional parameters to the LinkAccount method across multiple wallet implementations, allowing for a more flexible linking process. It adds defaultSessionIdOverride and forceWalletIds, enhancing guest authentication and wallet linking functionalities.

Detailed summary

  • Added defaultSessionIdOverride and forceWalletIds parameters to LinkAccount method in:
    • PrivateKeyWallet
    • SmartWallet
    • IThirdwebWallet
    • EcosystemWallet
  • Updated PreAuth_Guest to accept defaultSessionIdOverride.
  • Modified calls to PreAuth_Guest and PreAuth_SiweExternal to use new parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Jan 17, 2025

@0xFirekeeper 0xFirekeeper merged commit 40e1d56 into main Jan 17, 2025
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/session-id-override branch January 17, 2025 19:16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b50e1ed). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage        ?   76.58%           
=======================================
  Files           ?       28           
  Lines           ?     4804           
  Branches        ?      665           
=======================================
  Hits            ?     3679           
  Misses          ?      951           
  Partials        ?      174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants