Fixes #38185 - Secure HTTP(S) proxy password Setting #10432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
lfu
force-pushed
the
30137_remove_password_http_proxy_logging
branch
from
3f30a88 to
b025597
Compare
lfu
force-pushed
the
30137_remove_password_http_proxy_logging
branch
from
b025597 to
e989eea
Compare
|
@stejskalleos Do you think this would require some changes in downstream documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Password from
http_proxySetting is logged in plaintext to production.log.Solution: Add setting
http_proxy_usernameandhttp_proxy_passwordwhich is an encrypted value.