Cfe04 config meta data v2 #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kortemik
requested changes
May 19, 2025
| ( | ||
| id INT AUTO_INCREMENT PRIMARY KEY, | ||
| cfe_04_id INT NOT NULL, | ||
| name VARCHAR(255) NOT NULL, |
There was a problem hiding this comment.
i think name should be a reference to the same place that capture points it's indexes to, or something because these are essentially the same thing. i think it would be worth of some kind of meeting to sort this out.
| ( | ||
| id INT AUTO_INCREMENT PRIMARY KEY, | ||
| cfe_04_id INT NOT NULL, | ||
| name VARCHAR(255) NOT NULL, |
There was a problem hiding this comment.
i think name should be a reference to the same place that capture points it's sourcetypes to, or something because these are essentially the same thing. i think it would be worth of some kind of meeting to sort this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft 2 of cfe 04 config.json metadata tables.
Applied changes suggested internally and in the previous draft PR.
last_chance_index on cfe_04_global stays varchar until better time.