[Fix] Redis cluster to exceed the maximum number of connections #484
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on commands CLUSTER SLOTS 0 and CLUSTER NODES 0 cause shard 0 in the Redis cluster to exceed the maximum number of connections.
jq
approved these changes
Jan 15, 2025
| @@ -213,6 +214,12 @@ class RedisWrapper<RedisInstance, K, V, | |||
| return nullptr; | |||
| } | |||
|
|
|||
| int GenerateRedisRandomTag() { | |||
| static thread_local std::mt19937 generator(std::random_device{}()); | |||
| std::uniform_int_distribution<int> distribution(0, 16383); | |||
There was a problem hiding this comment.
make 16383 a const?
btw, any reason to pick 16383?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there are a large number of client NODES, the initialization commands CLUSTER SLOTS 0 and CLUSTER NODES 0 cause shard 0 in the Redis cluster to exceed the maximum number of connections.
Type of change
Checklist:
How Has This Been Tested?
Create a model running with hundreds of Redis tables and distributed in hundreds of nodes sharing same Redis cluster.