Skip to content
This repository was archived by the owner on Apr 10, 2024. It is now read-only.

Add testing for notebooks [WIP] #99

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

kmader
Copy link
Contributor

@kmader kmader commented Aug 13, 2018

I started to implement some basic testing for the notebooks in response to the comment here: #97 (comment)

kmader added 9 commits August 13, 2018 21:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
adding code to execute the notebooks with nbconvert and ensure there are no error messages (as mentioned in PR tensorflow#97)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
tweaking nbconvert code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
tweaking nbconvert code

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
adding jupyter client

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
show kernels and override default kernel name

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
adding ipykernel and self-installer

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
tweaking ipython kernel line

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
setting kernel_name to default

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
changing to use testkernel
@kmader
Copy link
Contributor Author

kmader commented Aug 13, 2018

The biggest open issues now are

  • print statements in python 3
  • !pip install messing up configurations

Sorry, something went wrong.

@ludwigschubert
Copy link
Contributor

ludwigschubert commented Aug 14, 2018

Oh, thanks, I’ll take a look!
I had found https://github.com/computationalmodelling/nbval which uses magic comments to to mark cells to be skipped over. I was mostly stuck on how to get non-random outputs, which seems critical for equality comparison.
Print statements etc we’ll just port to Python 3; we primarily want the main library to be backwards compatible for users stuck on Python 2 for now.

That being said, even just running the code would provide a layer of stability that lets us know when we break things. Thanks already for getting started; I may need some days to respond!

@ludwigschubert ludwigschubert marked this pull request as draft March 12, 2021 15:59
@ludwigschubert ludwigschubert self-assigned this Mar 12, 2021
@ludwigschubert ludwigschubert added the awaiting reply Waiting for third-party reply label Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting reply Waiting for third-party reply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants