Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add explicit error messages in "waitFor*" methods #652

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Jean-Beru
Copy link
Contributor

Display an explicit message when a waitFor* assertion fails to make debug easier.

@Jean-Beru Jean-Beru changed the title [Panther] add explicit error messages in "wait*" methods feat: add explicit error messages in "wait*" methods Dec 18, 2024
@Jean-Beru Jean-Beru changed the title feat: add explicit error messages in "wait*" methods feat: add explicit error messages in "waitFor*" methods Dec 18, 2024
@Jean-Beru Jean-Beru force-pushed the add-message-in-wait-methods branch from 9a585d3 to 913a1d1 Compare December 18, 2024 11:16
@dunglas dunglas merged commit 4009127 into symfony:main Jan 7, 2025
15 of 16 checks passed
@dunglas
Copy link
Member

dunglas commented Jan 7, 2025

Thanks!

@Jean-Beru Jean-Beru deleted the add-message-in-wait-methods branch January 7, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants