feat: add PANTHER_REDUCED_MOTION to limit animations #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Beru
force-pushed
the
add-reduced-motion
branch
4 times, most recently
from
0d04f2a to
83527aa
Compare
dunglas
requested changes
Jan 7, 2025
src/ProcessManager/ChromeManager.php
Outdated
| @@ -114,6 +114,11 @@ private function getDefaultArguments(): array | |||
| $args[] = '--no-sandbox'; | |||
| } | |||
|
|
|||
| // Prefer reduced motion, see https://developer.mozilla.org/fr/docs/Web/CSS/@media/prefers-reduced-motion | |||
| if ($_SERVER['PANTHER_REDUCED_MOTION'] ?? false) { | |||
There was a problem hiding this comment.
Suggested change
| if ($_SERVER['PANTHER_REDUCED_MOTION'] ?? false) { | |
| if (filter_var($_SERVER['PANTHER_REDUCED_MOTION'] ?? true, \FILTER_VALIDATE_BOOLEAN)) { |
(see #632)
| @@ -63,6 +64,14 @@ public function start(): WebDriver | |||
| $capabilities = DesiredCapabilities::firefox(); | |||
| $capabilities->setCapability('moz:firefoxOptions', $firefoxOptions); | |||
|
|
|||
| // Prefer reduced motion, see https://developer.mozilla.org/fr/docs/Web/CSS/@media/prefers-reduced-motion | |||
| if ($_SERVER['PANTHER_REDUCED_MOTION'] ?? false) { | |||
There was a problem hiding this comment.
Suggested change
| if ($_SERVER['PANTHER_REDUCED_MOTION'] ?? false) { | |
| if (filter_var($_SERVER['PANTHER_REDUCED_MOTION'] ?? true, \FILTER_VALIDATE_BOOLEAN)) { |
Jean-Beru
force-pushed
the
add-reduced-motion
branch
from
83527aa to
99ab383
Compare
I totally agree 🙂 |
|
Maybe make this config the default and introduce a |
|
It makes sense with I also added a test (and fixed a bug spotted by it). |
Jean-Beru
force-pushed
the
add-reduced-motion
branch
from
c9fe896 to
feb27a8
Compare
dunglas
approved these changes
Jan 8, 2025
|
Thank you! |
|
@dunglas FYI, I'm trying to understand why https://github.com/symfony/panther/actions/runs/12673280007/job/35319306027?pr=651 is failing |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a
PANTHER_REDUCED_MOTIONenvironment variable to set theprefers-reduced-motionCSS media feature toreduce.It could be useful to limit "flaky" tests which result in a
Facebook\WebDriver\Exception\ElementClickInterceptedException: Element <XXX> is not clickable at point (XXX, YYY) because another element XXX obscures itexception because an animation is still in progress.This CSS media feature is already supported by Bootstrap or the french DSFR.