feat: WebAuthN support #966
Draft
+19,465
−697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: WebAuthN Sign In, Sign Up and Options methods support
* added missing tests * add reject support for api calls * added todos for updating to latest cdi version when skipping tests --------- Co-authored-by: Victor Bojica <[email protected]>
✅ Deploy Preview for astounding-pegasus-21c111 canceled.
|
✅ Deploy Preview for precious-marshmallow-968a81 canceled.
|
porcellus
requested changes
Mar 12, 2025
.circleci/config_continue.yml
Outdated
| @@ -127,7 +150,7 @@ workflows: | |||
| tags: | |||
| only: /dev-v[0-9]+(\.[0-9]+)*/ | |||
| branches: | |||
| only: /test-cicd\/.*/ | |||
| only: /test-cicd\/.*|feat\/webauthn\/base/ | |||
| LINKING_TO_SESSION_USER_FAILED: { | ||
| EMAIL_VERIFICATION_REQUIRED: | ||
| "Cannot sign in / up due to security reasons. Please contact support. (ERR_CODE_013)", | ||
| "Cannot sign in / up due to security reasons. Please contact support. (ERR_CODE_26)", |
There was a problem hiding this comment.
please update the code to match the original format (3digits, leftpadded with 0)
lib/ts/recipe/webauthn/recipe.ts
Outdated
Comment on lines
195
to
201
| // If the loginmethod associated with the session has an email address, we move it to the top of the list (if it's already in the list) | ||
| if (sessionLoginMethod.email !== undefined && result.includes(sessionLoginMethod.email)) { | ||
| result = [ | ||
| sessionLoginMethod.email, | ||
| ...result.filter((email) => email !== sessionLoginMethod!.email), | ||
| ]; | ||
| } |
There was a problem hiding this comment.
I think we should keep this part.
…d pad error codes
This reverts commit d14c29b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)lib/ts/version.tsfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettyrecipe/thirdparty/providers/configUtils.tsfile,createProviderfunction.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.add-ts-no-check.jsfile to include thatsomeFunc: function () {..}).exportsinpackage.jsonRemaining TODOs for this PR