fix: handle missing expression type in protobuf import correctly #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the handling of `Expression` protobuf messages that do not of the `expression` type set. Such a message would be invalid Substrait but valid protobuf, so the import logic has to be able to handle that case gracefully. The PR now has a dedicated `case` for that case. Signed-off-by: Ingo Müller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of
Expressionprotobuf messages that do not of theexpressiontype set. Such a message would be invalid Substrait but valid protobuf, so the import logic has to be able to handle that case gracefully. The PR now has a dedicatedcasefor that case.