feat: elide attribute type with new StaticallyTypedAttrInterface
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
statically-typed-attr
branch
2 times, most recently
from
d3c98d6 to
02f7193
Compare
ingomueller-net
changed the title
StaticallyTypedAttrInterfaceStaticallyTypedAttrInterface [WIP]
ingomueller-net
force-pushed
the
statically-typed-attr
branch
from
02f7193 to
1877e60
Compare
ingomueller-net
changed the title
StaticallyTypedAttrInterface [WIP]StaticallyTypedAttrInterface
ingomueller-net
force-pushed
the
statically-typed-attr
branch
from
1877e60 to
efadd27
Compare
This allows to omit the type of an attribute from the assembly if it can be inferred from the attribute value. For example, the type is redundant in `#substrait.timestamp<100us> : !substrait.timestamp`. The built-in `TypedAttrInterface`, however, forces the appearance of the type in the assembly. The new interface is almost identical but does not enforce it. The PR also makes the two timestamp attributes implement that interface. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
statically-typed-attr
branch
from
efadd27 to
007fae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.