Restore testCoreEventsGet generated test #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it if we cannot find the identified event subclass added generated test testCoreEventsGet
prathmesh-stripe
approved these changes
Jan 17, 2025
prathmesh-stripe
pushed a commit
that referenced
this pull request
Jan 23, 2025
* Update generated code (#1793) * Update generated code for v1399 * Update generated code for v1409 * Update generated code for v1412 --------- Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> * Bump version to 16.4.0 * Added pull request template (#1797) * Add justfile, remove coveralls, and fix AUTOLOAD in CI (#1801) * add justfile and tweak CI + readme * debug test * Debugging * further debugging * restore original composer json * add more logging * maybe fix ci * Fix typo * fix test naming and pass autoload directly to recipe as arugment * Remove unused logline and fix typo * restore composer * remove extra log line * update justfile * add comments * update ci * revert to gh action * ensure dependencies are installed for format and test recipes (#1802) * Update generated code for v1439 * Update generated code for v1441 * Update generated code for v1441 * Update generated code for v1442 * Update generated code for v1443 * Update generated code for v1445 * Update generated code for v1446 * Update generated code for v1448 * Update generated code for v1449 * Update generated code for v1450 * Added CONTRIBUTING.md file (#1806) * minor justfile fixes (#1807) * made v2 event class concrete, and changed convertToStripeObject to use it if we cannot find the identified event subclass (#1805) * Update generated code for v1454 * added CONTRIBUTING.md * Update generated code for v1456 * Update generated code for v1457 * Update generated code for v1460 --------- Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com> Co-authored-by: Jesse Rosalia <[email protected]> Co-authored-by: David Brownman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We have generated example tests that test service endpoints. \Stripe\V2\Event is an abstract base class for V2 events, and the return type of EventService.retrieve. Because the Event class was abstract, we could not include it in convertToStripeObject and therefore could not include this generated test.
What?