Show payment method preview in Link inline verification view #5179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: ConsumerSession+PublishableKey.swift:17 warning: Initializer 'init(consumerSession:publishableKey:displayablePaymentDetails:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
mats-stripe
changed the title
mats-stripe
commented
Jul 22, 2025
Comment on lines
42
to
45
| let defaultCardBrand: String? | ||
| let defaultPaymentType: PaymentType? | ||
| let last4: String? | ||
| let numberOfSavedPaymentDetails: Int? |
mats-stripe
force-pushed
the
mats/lookup_with_customer_id
branch
from
e1e1cbf to
0bc2bfa
Compare
mats-stripe
force-pushed
the
mats/lookup_with_customer_id
branch
from
4ff4d34 to
830629d
Compare
|
Works now! 
|
Comment on lines
+62
to
+63
| customerID: elementsSession.customer?.customerSession.customer, | ||
| shouldPassCustomerIdToLookup: shouldPassCustomerIdToLookup |
There was a problem hiding this comment.
How about we only pass the customer ID if shouldPassCustomerIdToLookup?
Suggested change
| customerID: elementsSession.customer?.customerSession.customer, | |
| shouldPassCustomerIdToLookup: shouldPassCustomerIdToLookup | |
| customerID: shouldPassCustomerIdToLookup ? elementsSession.customer?.customerSession.customer : nil |
| @@ -27,12 +34,42 @@ struct LinkInlineVerificationView: View { | |||
| self.onComplete = onComplete | |||
| } | |||
|
|
|||
| private var scaledSeparatorWidth: CGFloat { | |||
| max(Constants.baseSeparatorWidth, 0.5) // Ensure separator is always visible | |||
There was a problem hiding this comment.
This is always 1, no?
| .resizable() | ||
| .scaledToFit() | ||
| .frame(height: 20) | ||
| HStack(spacing: scaledContentSpacing) { |
There was a problem hiding this comment.
Nit: The paymentMethodPreview.last4 doesn't seem to be properly aligned with the icon. In the screenshots, the text sits a little too high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the customer's payment method preview to the Link inline verification view.
Motivation
📈
Testing
Note that the Link logo doesn't show up on previews, so it's a blue box instead here:
Changelog
N/a