Refactor collapsing list view to be reusable. #5048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: LinkCollapsingListView.swift:98 warning: Parameter 'sender' is unused
LinkPaymentMethodListView-Cell.swift:252 warning: Parameter 'sender' is unused
LinkPaymentMethodListView.swift:132 warning: Parameter 'animated' is unused
PayWithLinkViewController-WalletViewModel.swift:25 warning: Property 'shippingAddresses' is assigned, but never usedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
nschris-stripe
force-pushed
the
nschris/shippingAddressSelection
branch
from
df2b246 to
79e8b9d
Compare
| updateAccessibilityContent() | ||
| } | ||
| } | ||
|
|
||
| // Indicates whether the header should appear collapsable or not. | ||
| // The header is collapsable when the currently selected payment method is supported. |
There was a problem hiding this comment.
Do we need to change this comment?
Suggested change
| // The header is collapsable when the currently selected payment method is supported. | |
| // The header is collapsable when the currently selected item is supported. |
Comment on lines
+40
to
+41
| let stackView = UIStackView(arrangedSubviews: [ | ||
| ]) |
There was a problem hiding this comment.
Suggested change
| let stackView = UIStackView(arrangedSubviews: [ | |
| ]) | |
| let stackView = UIStackView() |
| override func updateAccessibilityContent() { | ||
| super.updateAccessibilityContent() | ||
| if isExpanded { | ||
| accessibilityLabel = collapsedLabel.text |
There was a problem hiding this comment.
Should it not be headingLabel?
gbirch-stripe
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change refactors the collapsing list functionality to be reusable. This is in preparation to display shipping addresses in the native link view.
Demo
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-06-25.at.15.35.26.mp4