Set correct allow_redisplay value for spms with link #4501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
commented
Jan 24, 2025
| @@ -505,7 +510,8 @@ extension PaymentSheet { | |||
| let shouldSave = false // always false, as we don't show a save-to-merchant checkbox in Link VC | |||
|
|
|||
| if elementsSession.linkPassthroughModeEnabled { | |||
| linkAccount.sharePaymentDetails(id: paymentDetails.stripeID, cvc: paymentDetails.cvc) { result in | |||
| // allowRedisplay is nil since we are not saving a payment method. | |||
| linkAccount.sharePaymentDetails(id: paymentDetails.stripeID, cvc: paymentDetails.cvc, allowRedisplay: nil) { result in | |||
There was a problem hiding this comment.
@davidme-stripe - a bit unclear here on capturing allowRedisplay. Is it possible to have a checkbox when given .withPaymentDetails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set allow_redisplay value when signing up for link and saving a new payment method
Motivation
allow_redisplay was not being set.
Testing
Updated existing test
Changelog