Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container image support #19

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Add container image support #19

merged 4 commits into from
Nov 24, 2023

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 24, 2023

This adds basic support for replacing container image references with
references that include the digest.

@JAORMX JAORMX requested a review from jhrozek November 24, 2023 07:49
stacklokbot
stacklokbot previously requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder found vulnerable dependencies in this PR. Either push an updated
version or accept the proposed changes. Note that accepting the changes will
include Minder as a co-author of this PR.

go.sum Outdated Show resolved Hide resolved
@stacklokbot stacklokbot dismissed their stale review November 24, 2023 07:50

Previous Minder review was dismissed because the PR was updated.

stacklokbot
stacklokbot previously requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder found vulnerable dependencies in this PR. Either push an updated
version or accept the proposed changes. Note that accepting the changes will
include Minder as a co-author of this PR.

go.sum Outdated Show resolved Hide resolved
@JAORMX
Add container image support
6d63128 
This adds basic support for replacing container image references with
references that include the digest.
@stacklokbot stacklokbot dismissed their stale review November 24, 2023 07:51

Previous Minder review was dismissed because the PR was updated.

stacklokbot
stacklokbot previously requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder found vulnerable dependencies in this PR. Either push an updated
version or accept the proposed changes. Note that accepting the changes will
include Minder as a co-author of this PR.

go.sum Outdated Show resolved Hide resolved
@stacklokbot stacklokbot dismissed their stale review November 24, 2023 07:57

Previous Minder review was dismissed because the PR was updated.

stacklokbot
stacklokbot reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

stacklokbot
stacklokbot reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

stacklokbot
stacklokbot reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@stacklokbot stacklokbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minder analyzed this PR and found no vulnerable dependencies.

jhrozek
jhrozek approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean code.

@JAORMX JAORMX merged commit 82768f4 into main Nov 24, 2023
4 checks passed
@JAORMX JAORMX deleted the containerimage branch November 24, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stacklokbot stacklokbot stacklokbot left review comments

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAORMX @jhrozek @stacklokbot