Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bound port on ForwardedPortDynamic after connection (in case original was passed as zero) #1577

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Update bound port on ForwardedPortDynamic after connection (in case original was passed as zero) #1577

merged 2 commits into from
Jan 20, 2025

Conversation

timyhac
Copy link
Contributor

@timyhac timyhac commented Jan 19, 2025

Update the bound port after connection (in case original was passed as zero).
The logic was copied from ForwardedPortLocal into ForwardedPortDynamic.

@TimCantleBucherMunicipal TimCantleBucherMunicipal mentioned this pull request Jan 19, 2025
Closed
@Rob-Hague Rob-Hague linked an issue Jan 20, 2025 that may be closed by this pull request
Offer/expose dynamic port assignment for ForwardedPortDynamic #1575
Closed
Rob-Hague
Rob-Hague approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wrote a couple of tests over the weekend (not submitted yet) so nothing further needed

@Rob-Hague Rob-Hague merged commit 9c454ba into sshnet:develop Jan 20, 2025
3 checks passed
@timyhac timyhac deleted the #1575 branch January 20, 2025 08:24
@timyhac
Copy link
Contributor Author

timyhac commented Jan 20, 2025

Cheers! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob-Hague Rob-Hague Rob-Hague approved these changes

@drieseng drieseng Awaiting requested review from drieseng drieseng is a code owner

@WojciechNagorski WojciechNagorski Awaiting requested review from WojciechNagorski WojciechNagorski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer/expose dynamic port assignment for ForwardedPortDynamic
2 participants
@timyhac @Rob-Hague