Split EventListener.retryDecision into retryDecision and followUpDecision #8796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion retryDecision has an exception, and is related to connectivity failures. followUpDecision has an intermediate response, and is related to redirects and auth challenges. This drops the reason strings, which have 'logging brain' and I want to push our users towards 'metrics brain'.
yschimke
reviewed
May 23, 2025
| * @param networkResponse the intermediate response that may require a follow-up request. | ||
| * @param nextRequest the follow-up request that will be made. Null if no follow-up will be made. | ||
| */ | ||
| open fun followUpDecision( |
There was a problem hiding this comment.
Yep, nice. When documented properly, those are clearly two separate things.
yschimke
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retryDecision has an exception, and is related to connectivity failures.
followUpDecision has an intermediate response, and is related to redirects and auth challenges.
This drops the reason strings, which have 'logging brain' and I want to push our users towards 'metrics brain'.