Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removal of dependencies from the dependencies selection UI #1710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aloussase
Copy link

Users might misclic or change their mind about adding a dependency. Having to close the dialog in order to remove the dependency is unnecessary extra work.

This makes it so that the selected dependencies list is shown inside the dialog in a non-obstrusive way so that users can see what they've chosen so far and potentially remove them.

Screen.Recording.2025-01-26.at.12.02.56.PM.mov

Users might misclic or change their mind about adding a dependency.
Having to close the dialog in order to remove the dependency is unnecessary
extra work.

This makes it so that the selected dependencies list is shown inside the
dialog in a non-obstrusive way so that users can see what they've chosen
so far and potentially remove them.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 26, 2025
@mhalbritter mhalbritter changed the title Add dependencies list to dependencies dialog Allow removal of dependencies from the dependencies selection UI Jan 27, 2025
@mhalbritter
Copy link
Contributor

Hello,

first of all, thanks for this PR! We talked about this in our meeting and we agree that the current behavior of the list is not optimal.

We looked at your design in your video, and while it improves things, we'd like to propose something:

what about, instead of the green bubbles showing up on the top when you select a dependency, the dependency would stay in the list but get a different colored background. That way the user would see all selected dependencies (because they are colored), is able to de-select them by clicking on them again and there's no problem with scrolling when a lot of dependencies are selected.

That's essentially the same behavior as multi-select lists in operating systems and a lot of UIs: Ctrl+Click a deselected entry to select it and the background color indicates that it's selected. Ctrl+Click it again while selected deselects it, restoring the original color.

We think that this would work here, too.

Would you be willing to implement that idea?

@mhalbritter mhalbritter added status: waiting-for-feedback We need additional information before we can continue and removed for: team-meeting labels Feb 7, 2025
@aloussase
Copy link
Author

Hello @mhalbritter ,

Yes I agree with the new proposed design. I just did as I did because I did not know if you'd like any changes to the list.

I can work on this new design :)

Thanks

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants