fix(Turntable): resolve broken styles and features caused by major changes in Spotify and FAD, along with pre-existing feature defects #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotify v1.2.57 use React v18.3.1, and in this version of React, render API will add FAD component's context menu event listener to the `#fad-main` container element, that's why the handleFADContextMenu hander is add to this container element here. Otherwise, the handleFADContextMenu hander will be called before the FAD's hander, at this time, the config popup modal can't be get because it was created in the FAD's hander.
…uttons and remove no longer necessary logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1085