-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/edit: adds the context for the edit command #6924
Conversation
const legacyMetadata = { | ||
intent: task.intent, | ||
mode: task.mode, | ||
source: task.source, | ||
...telemetryMetadata, | ||
editContext: editContextData, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akalia25
Similar to the previous PR, we are logging this additional context for the edit command. The additional context will be wrapped under the editContext
field. Can we add this to backend ?
Also, please let me know if you spot anything in the PR related to telemetry :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hitesh-1997 , thank you for flagging this. I have added editContext
as a key that contains sensitive information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as a reminder all the data within editContext
will be redacted on v2_events
, so if anything is non sensitive and would be useful to store in v2_events
for analytics, feel free to put it outside the editContext
key (i.e. selectionRange
if needed)
metadata: { | ||
...metadata, | ||
recordsPrivateMetadataTranscript: editContextData === undefined ? 0 : 1, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akalia25
I added recordsPrivateMetadataTranscript
field to in the metadata, is this sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect! 🔥 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Data backend changes completed to mark editContext
as a key containing sensitive data.
297c36c
to
009f001
Compare
Context
dotCom
users and the who are in the feature flag.Test plan
cody-edit-context-logs-collection-flag
feature flag.