Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Smart Apply): Show Reapply for applied code blocks #6898

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Jan 31, 2025

Description

closes https://linear.app/sourcegraph/issue/CODY-4826/smart-apply-show-reapply-to-indicate-applied-state

Primary purpose of these changes:

  • Give a UI indication of when a code block has already been applied and accepted. Especially useful when a user is actioning multiple code blocks in a response
  • Make it obvious to the user that they can re-apply a codeblock if something went wrong, or they weren't happy with the result
ReapplyBtn.mov

Test plan

  1. Make smart applies
  2. Click "Apply"
  3. Click "Accept"
  4. Observe that "Reapply" appears

@@ -30,3 +30,5 @@ export const CloseIcon =
'<svg role="img" width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" fill="currentColor"><path fill-rule="evenodd" clip-rule="evenodd" d="M8 8.707l3.646 3.647.708-.707L8.707 8l3.647-3.646-.707-.708L8 7.293 4.354 3.646l-.707.708L7.293 8l-3.646 3.646.707.708L8 8.707z"/></svg>'

export const TerminalIcon = '<i class="codicon codicon-terminal tw-align-middle"></i>'

export const RefreshIcon = '<i class="codicon codicon-refresh tw-align-middle"></i>'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abeatrix Do you know if these icons are automatically available in JetBrains? (I see you added the Terminal one above)

@umpox umpox enabled auto-merge (squash) January 31, 2025 14:56
@umpox umpox requested review from a team February 4, 2025 10:53
Copy link
Contributor

@hitesh-1997 hitesh-1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!

@umpox umpox merged commit 0ac886a into main Feb 4, 2025
25 checks passed
@umpox umpox deleted the tr/add-reapply-state branch February 4, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants