Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shimmer effect to stop button #6816

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

taiyab
Copy link
Contributor

@taiyab taiyab commented Jan 27, 2025

This PR introduces a shimmer effect to the stop button as the LLM is generating.

CleanShot.2025-01-27.at.13.14.16.mp4

Test plan

Tested locally, manually.

@taiyab taiyab requested a review from thenamankumar January 27, 2025 13:15
@rrhyne
Copy link
Contributor

rrhyne commented Jan 27, 2025

Side note: it's really inconvenient and not very semantic that the stop button is in the follow-up. Should we place it to right of the status?

@thenamankumar thenamankumar enabled auto-merge (squash) January 29, 2025 05:26
@taiyab
Copy link
Contributor Author

taiyab commented Jan 29, 2025

Side note: it's really inconvenient and not very semantic that the stop button is in the follow-up. Should we place it to right of the status?

Yep. We can move this in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants