Fix OpenTelemetryService initialisation code #6775
Closed
+34
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
externalAuthRefreshChanges
not having initial value which was blocking the configurationI discovered one problem though.
Restarting trace exported does not really work.
It always throw an error:
We catch this error and re-initialisation seems to be passing, but then
CodyTraceExporter::export
is never called after that.Test plan
Tested with debugger by:
"cody.experimental.tracing": true
to the configCodyTraceExporter::export
was executedThen
cody.experimental.tracing
tofalse
CodyTraceExporter::export
was NOT executed