Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement isCloseTo function #1012

Merged
merged 13 commits into from
Mar 14, 2025
Merged

feat: Implement isCloseTo function #1012

merged 13 commits into from
Mar 14, 2025

Conversation

aleksanderkatan
Copy link
Collaborator

@aleksanderkatan aleksanderkatan commented Mar 13, 2025 •
edited
Loading

Changes:

  • implement isCloseTo function,
  • add tests for isCloseTo and atan2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2025 •
edited
Loading

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1012
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1e34f8ba5ddca773bfd215d77065f24e7c6bd1a2

benchmark
view benchmark

commit
view commit

@aleksanderkatan aleksanderkatan marked this pull request as ready for review March 13, 2025 12:38
@aleksanderkatan aleksanderkatan changed the base branch from release to main March 13, 2025 12:58
@aleksanderkatan aleksanderkatan marked this pull request as draft March 13, 2025 13:18
@aleksanderkatan aleksanderkatan marked this pull request as ready for review March 14, 2025 11:22
@aleksanderkatan aleksanderkatan linked an issue Mar 14, 2025 that may be closed by this pull request
feat: Implement isCloseTo function to std #1007
Closed
iwoplaza
iwoplaza approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@iwoplaza iwoplaza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💜

@aleksanderkatan aleksanderkatan merged commit e619b6f into main Mar 14, 2025
6 checks passed
@mhawryluk mhawryluk deleted the feat/implement-iscloseto-function branch March 14, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwoplaza iwoplaza iwoplaza approved these changes

@mhawryluk mhawryluk Awaiting requested review from mhawryluk

@reczkok reczkok Awaiting requested review from reczkok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Implement isCloseTo function to std
2 participants
@aleksanderkatan @iwoplaza