Skip to content

[Framework] Apply template method design pattern to BaseMatrixProjectionMethod #5465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olivierrochel-inria
Copy link

changed:

  • projectMatrixToGlobalMatrix

Please not that hasPairStates has been made non virtual in the seconde commit (following discussions between us)- to be reviewed carefully.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@olivierrochel-inria olivierrochel-inria added pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code labels May 13, 2025
@olivierrochel-inria
Copy link
Author

[ci-build][with-all-tests]

@olivierrochel-inria
Copy link
Author

[ci-build][with-all-tests]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant