Skip to content

Update default API version to v19.0 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2024
Merged

Update default API version to v19.0 #389

merged 4 commits into from
May 22, 2024

Conversation

wynksaiddestroy
Copy link
Contributor

@wynksaiddestroy wynksaiddestroy commented Apr 18, 2024

omniauth-facebook still uses Graph API version 5.0 as the default, which was shut off in February 2022.
The current API version is v19.0. A quick google search didn't yield any changes to the OAuth part of the API. So I assume it's safe to use the current version of the API.
#374 addressed the problem already.
On the side I updated the CI test matrix and removed all unmaintained Ruby versions.

@simi
Copy link
Owner

simi commented Apr 19, 2024

Thanks @wynksaiddestroy, would you mind to add Bigdecimal to gemfile to fix head build as well?

@wynksaiddestroy
Copy link
Contributor Author

Thanks @wynksaiddestroy, would you mind to add Bigdecimal to gemfile to fix head build as well?

Thanks for the quick response ❤️
The gemspec file now includes bigdecimal as a dependency.
I've also simplified the CI workflow further.

@svoop
Copy link

svoop commented May 7, 2024

Just a friendly heads-up: Thanks for cutting a release soonish, the v13 API won't work after May 28, so it would be nice to have a few days to update. And thanks for this PR, @wynksaiddestroy !

@svoop
Copy link

svoop commented May 22, 2024

@simi This is getting kind of urgent now. The currently used API version is shut down in less than a week on May 28. Thanks a lot for merging and cutting a release as soon as you can!

@simi simi merged commit b5eaff1 into simi:master May 22, 2024
5 checks passed
@simi
Copy link
Owner

simi commented May 22, 2024

Thanks for the PR and comments. I'll cut a release soon. 🙏

@simi
Copy link
Owner

simi commented May 22, 2024

🥳 https://rubygems.org/gems/omniauth-facebook/versions/10.0.0

@svoop
Copy link

svoop commented May 23, 2024

Great, thanks a bunch, @simi and @wynksaiddestroy !!

@wynksaiddestroy wynksaiddestroy deleted the update-default-api-version branch May 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants