Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support building for wasm32-wasi targets. #168

Merged

Conversation

karthik2804
Copy link
Contributor

This PR adds the ability to compile for wasm32-wasi target. I was attempting to build an app using Spin. An example application can be found here.

I am happy to update CI to test for the wasm32-wasi target as well.

@seungjin
Copy link

So exciting to use this for my spin apps!

@silvia-odwyer
Copy link
Owner

@karthik2804 Hi Karthik,
Thanks very much for your contribution! It's fantastic that the library will support building for wasm32-wasi targets. If you'd like to update the CI, we're always open to contributions and pull requests, so do feel free.

Everything looks great to me, so I'll merge the changes now ✅ Thanks again!

@silvia-odwyer silvia-odwyer merged commit 707b7a8 into silvia-odwyer:master Apr 3, 2024
5 checks passed
@karthik2804 karthik2804 deleted the wasi_feature_gating branch April 3, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants