Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not unconditionally fetch slang and imgui #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

expipiplus1
Copy link
Contributor

Also add an option to use local imgui source

Also add an option to use local imgui source
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@westlicht
Copy link
Collaborator

what is the reason for needing the local imgui option?

@ccummingsNV
Copy link
Collaborator

In theory if it wasn't for the dev comment breaking CMAKE, I'd say it looked correct, but I'm also a little concerned about deciding to add the option for a 'local imgui'. If we start down that path, do we need to provide a 'local X' for any extra dependencies? Unless there's a key reason for needing it? (eg a custom build of imgui with specific features?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants