Integrate turbomind into sgl-kernel #2999
Open
+617
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjmsong
requested review from
zhyncs,
ispobock,
HandH1998,
BBuf,
yizhang2077 and
merrymercy
as code owners
zhyncs
requested changes
Jan 20, 2025
sgl-kernel/MANIFEST.in
Outdated
| @@ -0,0 +1,2 @@ | |||
| include src/sgl-kernel/turbomind/lib/_turbomind_ext.cpython-312-x86_64-linux-gnu.so | |||
There was a problem hiding this comment.
Why is the Python version specified here?
There was a problem hiding this comment.
because pybind11 is used in building
There was a problem hiding this comment.
We can’t hardcode the Python version
| @@ -0,0 +1 @@ | |||
| import sgl_kernel.turbomind.lib._turbomind_ext as _turbomind_ext | |||
… into turbomind_integrate
|
BTW Can we only use the C++ and CUDA code from |
|
BTW we should ensure the PR Test (sgl-kernel) is successful. |
… into turbomind_integrate
zhyncs
requested changes
Jan 26, 2025
sgl-kernel/build.sh
Outdated
| @@ -22,6 +22,9 @@ docker run --rm \ | |||
| export SGL_KERNEL_ENABLE_SM90A=${ENABLE_SM90A} && \ | |||
| mkdir -p /usr/lib/x86_64-linux-gnu/ && \ | |||
| ln -s /usr/local/cuda-${CUDA_VERSION}/targets/x86_64-linux/lib/stubs/libcuda.so /usr/lib/x86_64-linux-gnu/libcuda.so && \ | |||
| cd /sgl-kernel && \ | |||
| cd /sgl-kernel/3rdparty/turbomind && \ | |||
There was a problem hiding this comment.
We should handle the build process internally within setup.py, not this way.
sgl-kernel/setup.py
Outdated
| extra_link_args = [ | ||
| "-Wl,-rpath,$ORIGIN/../../torch/lib", | ||
| "-L/usr/lib/x86_64-linux-gnu", | ||
| f"{str(root)}/3rdparty/turbomind/build/lib/libgemm2.a", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhyncs
Checklist