Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SupportedDeviceTable SeeAll button position #581

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

mikewuu
Copy link
Contributor

@mikewuu mikewuu commented Jan 8, 2024

closes #580

Should now be centered on the final row.

Before

image

After

CleanShot 2024-01-08 at 22 14 49

@@ -173,6 +173,7 @@ $row-padding: 8px;
0 1px 1px 0 rgb(16 27 37 / 10%),
0 1px 8px 0 rgb(46 69 82 / 12%);
position: absolute;
bottom: -13px; // (64px row - 30px button - 8px padding) / 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use sass or css math to compute this instead of the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good call, thanks.

Updated in 5e67dc0

@mikewuu mikewuu merged commit bfea0b3 into main Jan 9, 2024
16 checks passed
@mikewuu mikewuu deleted the see-all-button-fix branch January 9, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported devices component "see all" button is in wrong place
2 participants