Remove inside faces #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Re-enabled transparency (since this was the only thing blocking it from being enabled) -Currently bugged since ALL faces are removed
This requires a modified version of three.js which I will create a PR for soon on the three.js repo
-This doesn't work yet, most likely due to ThreeCSG interfering with something
Conflicts: index.html
Conflicts: index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the inside faces of the cylinders and allows us to re-enable transparency. Before, the cylinders would have inside faces that were blatantly obvious when transparency was enabled. Now that the inside faces are removed, there should be minor performance improvements as well as nice-looking transparency.
In order for this change to happen, I had to manually edit the three.js source code to allow selective editing of the open ends. This is obviously undesirable, so I'll be creating a PR on the three.js repo soon.
Things that need to be done before this can be merged: