-
Notifications
You must be signed in to change notification settings - Fork 2
chore: update teams.ts #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@moul is attempting to deploy a commit to the Samouraï Coop Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe update restructures the team assignments by moving four members from the "Core Team" to a newly created "All in Bits" team, which also includes two additional members. A new "Grants" team is introduced with eight members. Several team member lists are reformatted for readability, without altering their composition. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/constants/teams.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@typescript-eslint/parser' declared in '.eslintrc.js': Cannot find module '@typescript-eslint/parser'
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/constants/teams.ts (2)
92-97
: Remove trailing whitespace.The formatting looks good, but there's trailing whitespace after 'jeronimoalbi' on line 94.
- 'jeronimoalbi', + 'jeronimoalbi',
98-111
: New "Grants" team looks good, but fix trailing whitespace.The new team structure is syntactically correct and properly formatted. There's trailing whitespace after 'Chaegnal' on line 103 that should be removed.
- 'Chaegnal', + 'Chaegnal',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/constants/teams.ts
(2 hunks)
🔇 Additional comments (5)
src/constants/teams.ts (5)
30-31
: LGTM on Core Team restructuring.The Core Team member list has been properly restructured, with four members moved to the new "All in Bits" team as indicated in the summary.
32-43
: New "All in Bits" team looks good, but check for color conflict.The new team structure is syntactically correct and properly formatted. However, both "All in Bits" and "VarMeta" teams use the 'yellow' color, which could cause visual confusion in the UI.
Consider using a different color for one of these teams to avoid potential UI conflicts:
{ name: 'All in Bits', - color: 'yellow', + color: 'orange', members: [
47-52
: LGTM on Onbloc team formatting.The multiline array formatting improves readability without changing the team composition.
57-61
: LGTM on VarMeta team formatting.The multiline array formatting improves readability without changing the team composition.
83-87
: LGTM on Berty team formatting.The multiline array formatting improves readability without changing the team composition.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
manual edit, not sure if i made a syntax error
Summary by CodeRabbit
New Features
Refactor