[FEATURE] Add RemoveAddLLrefForTCAdescrMethodCallRector #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| */ | ||
| public function refactor(Node $node): ?Node | ||
| { | ||
| if (! $node instanceof StaticCall) { |
There was a problem hiding this comment.
this check is useless as this will always be the case because of the nodeTypes filter above
|
|
||
| if (! $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType( | ||
| $node, | ||
| new ObjectType(ExtensionManagementUtility::class) |
There was a problem hiding this comment.
Do not import class names from TYPO3. See other rules how it is done.
| return null; | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
return null does nothing and does not remove the node.
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
| CODE_SAMPLE | ||
| ), | ||
|
|
|
|
||
| use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; | ||
|
|
||
| defined('TYPO3') or die(); |
|
Please also link the corresponding issue to this rule in the commit message and in the future please use a new branch to keep your main branch clean, otherwise you have to hard reset it after a merge. |
Co-authored-by: Simon Schaufelberger <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.