Rollup of 6 pull requests #136534
Merged
Rollup of 6 pull requests #136534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing signed type There was a macro parameter giving signed impls access to the corresponding unsigned type, but not the other way around. This will allow implementing methods converting in both directions.
- duplicates of crateresolve1 are used in a couple error-codes tests - also fix the note in crateresolve1 to link to these other duplicates, now that E0523 has been merged into E0464
`rustc_middle` and `rustc_query_system` both have a file called `dep_node.rs` with a big comment at the top, and the comments are very similar. The one in `rustc_query_system` looks like the original, and the one in `rustc_middle` is a copy with some improvements. This commit removes the comment from `rustc_middle` and updates the one in `rustc_query_system` to include the improvements. I did it this way because `rustc_query_system` is the crate that defines `DepNode`, and so seems like the right place for the comment.
The same comments are on the `DepNodeExt` trait and the single impl of that trait, immediately below. This commit eliminates the duplication.
It has a single call site and removing it makes the code simpler. Perhaps there were more uses at some point in the past?
The `field_name`/`field_ty` don't need to be parameters, they can be hardcoded.
- Mention THIR. - Removed mentions of non-existent READMEs.
I *think* this addresses what the `FIXME` comments are asking for.
add UnsafeCell direct access APIs - Implementation for ACP: rust-lang/libs-team#521 - Tracking issue rust-lang#136327
…ieyouxu Some `rustc_middle` cleanups Small cleanups I found while looking closely at this code. r? `@jieyouxu`
std::fs: further simplify dirent64 handling Follow-up to rust-lang#134678. r? `@tgross35`
Fix last compare-mode false negatives in tests This PR is a continuation of rust-lang#136310 and fixes the last remaining cases of false negatives when running tests under a compare-mode. With these normalizations, all the compare-mode failures in `next-solver` (and `polonius`) should now be real, actual differences in diagnostics.
…nsigned, r=dtolnay Add `cast_signed` and `cast_unsigned` methods for `NonZero` types Requested in rust-lang#125882 . Note that this keeps the same names as the methods currently present on other integer types. If we want to rename them, we can rename them all at the same time.
…rieb Add note about `FnPtr` trait being exposed as public bound
rustbot
added
A-query-system
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 7b31983d55 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (01e4f19): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -1.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 4.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 778.8s -> 778.094s (-0.09%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
rustc_middlecleanups #136465 (Somerustc_middlecleanups)cast_signedandcast_unsignedmethods forNonZerotypes #136511 (Addcast_signedandcast_unsignedmethods forNonZerotypes)FnPtrtrait being exposed as public bound #136518 (Add note aboutFnPtrtrait being exposed as public bound)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup