Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move dist-x86_64-msvc to windows 2025 #136483

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

marcoieni
Copy link
Member

This job is very flaky: it failed 19 times in the last month.

image

See also this zulip thread and this GitHub issue.

Windows 2025 is working well for x86_64-msvc jobs since we moved them in #135632 so we want to move this runner as well to try to reduce the flakiness.

try-job: dist-x86_64-msvc

@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 3, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
…5, r=<try>

ci: move dist-x86_64-msvc to windows 2025

try-job: dist-x86_64-msvc
@bors
Copy link
Contributor

bors commented Feb 3, 2025

⌛ Trying commit d4dce76 with merge 50541ea...

@bors
Copy link
Contributor

bors commented Feb 3, 2025

☀️ Try build successful - checks-actions
Build commit: 50541ea (50541ea39767240c47cffcc02ed07ff7638f35dc)

@Kobzol
Copy link
Contributor

Kobzol commented Feb 3, 2025

You can r=me (in case you want to do more try builds).

@marcoieni
Copy link
Member Author

I noticed some differences:

In the image, the try build is on the left, while on the right there's the latest auto build.
image

As you can see, the try build doesn't have Run tests and has less CI artifacts. Is it normal?

@Kobzol
Copy link
Contributor

Kobzol commented Feb 3, 2025

Yes, try builds don't run opt-dist tests by default and build less components overall, it's fine. This is tied to DIST_TRY_BUILD.

@marcoieni
Copy link
Member Author

@bors r=Kobzol

@bors
Copy link
Contributor

bors commented Feb 3, 2025

📌 Commit d4dce76 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2025
@tgross35
Copy link
Contributor

tgross35 commented Feb 3, 2025

@bors p=10 rollup=never

Before this job fails anything else

@bors
Copy link
Contributor

bors commented Feb 3, 2025

⌛ Testing commit d4dce76 with merge affdb59...

@bors
Copy link
Contributor

bors commented Feb 4, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing affdb59 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2025
@bors bors merged commit affdb59 into rust-lang:master Feb 4, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 4, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (affdb59): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.9% [4.9%, 4.9%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.6% [-3.6%, -3.6%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [-3.6%, 4.9%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.951s -> 779.81s (0.11%)
Artifact size: 328.87 MiB -> 328.85 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants