-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move dist-x86_64-msvc to windows 2025 #136483
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
@bors try |
…5, r=<try> ci: move dist-x86_64-msvc to windows 2025 try-job: dist-x86_64-msvc
☀️ Try build successful - checks-actions |
You can r=me (in case you want to do more try builds). |
I noticed some differences: In the image, the try build is on the left, while on the right there's the latest auto build. As you can see, the try build doesn't have |
Yes, try builds don't run opt-dist tests by default and build less components overall, it's fine. This is tied to |
@bors r=Kobzol |
@bors p=10 rollup=never Before this job fails anything else |
☀️ Test successful - checks-actions |
Finished benchmarking commit (affdb59): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 778.951s -> 779.81s (0.11%) |
This job is very flaky: it failed 19 times in the last month.
See also this zulip thread and this GitHub issue.
Windows 2025 is working well for
x86_64-msvc
jobs since we moved them in #135632 so we want to move this runner as well to try to reduce the flakiness.try-job: dist-x86_64-msvc