Remove generic //@ ignore-{wasm,wasm32,emscripten} in tests
#136476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Remove redundant `//@ ignore-{wasm,wasm32,emscripten}` in tests
Follow-up to rust-lang#135926.
When `//@ needs-{unwind,subprocess}` are the suitable capability guards.
Resolves rust-lang#135923.
r? `@ghost`
try-job: test-various
|
Er, actually, I should've just deleted them and see what fails first |
jieyouxu
added
the
rla-silenced
jieyouxu
changed the title
//@ ignore-{wasm,wasm32,emscripten} in tests//@ ignore-{wasm,wasm32,emscripten} in tests
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 3, 2025
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests
Follow-up to rust-lang#135926.
In favor of capability-based guards `//@ needs-{unwind,subprocess}`.
Resolves rust-lang#135923.
r? `@ghost`
try-job: test-various
|
☀️ Try build successful - checks-actions |
jieyouxu
removed
the
rla-silenced
jieyouxu
force-pushed
the
panic-panic-panic
branch
from
cd4c655 to
190a8a6
Compare
|
Try-job is green, so @rustbot ready r? compiler |
jieyouxu
added
the
A-testsuite
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2025
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests
Follow-up to rust-lang#135926.
In favor of capability-based guards `//@ needs-{unwind,subprocess}`.
Resolves rust-lang#135923.
r? `@ghost`
try-job: test-various
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 3, 2025
Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests
Follow-up to rust-lang#135926.
In favor of capability-based guards `//@ needs-{unwind,subprocess}`.
Resolves rust-lang#135923.
r? ``@ghost``
try-job: test-various
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#136289 (OnceCell & OnceLock docs: Using (un)initialized consistently) - rust-lang#136299 (Ignore NLL boring locals in polonius diagnostics) - rust-lang#136411 (Omit argument names from function pointers that do not have argument names) - rust-lang#136430 (Use the type-level constant value `ty::Value` where needed) - rust-lang#136476 (Remove generic `//@ ignore-{wasm,wasm32,emscripten}` in tests) - rust-lang#136484 (Notes on types/traits used for in-memory query caching) - rust-lang#136493 (platform-support: document CPU baseline for x86-32 targets) - rust-lang#136498 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #135926.
In favor of capability-based guards
//@ needs-{unwind,subprocess}.Resolves #135923.
r? @ghost
try-job: test-various