Fix accidentally not emitting overflowing literals lints anymore in patterns #136393

oli-obk · 2025-02-01T17:22:18Z

This was regressed in #134228 (not in beta yet).

The issue was that previously we nested hir::Expr inside hir::PatKind::Lit, so it was linted by the expression code.

So now I've set it up for visitors to be able to directly visit literals and get all literals

rustbot · 2025-02-01T17:22:27Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/type/pattern_types/overflowing_literals_in_patterns.rs

rustbot · 2025-02-01T22:16:56Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

compiler-errors · 2025-02-02T14:34:51Z

r? compiler-errors @bors r+ rollup=never

bors · 2025-02-02T14:34:54Z

📌 Commit 663191d has been approved by compiler-errors

It is now in the queue for this repository.

oli-obk · 2025-02-03T11:58:44Z

@bors r-

oli-obk · 2025-02-03T11:59:04Z

@bors try @rust-timer queue

Let's run perf and rollup if clean

…, r=<try> Fix accidentally not emitting overflowing literals lints anymore in patterns This was regressed in rust-lang#134228 (not in beta yet). The issue was that previously we nested `hir::Expr` inside `hir::PatKind::Lit`, so it was linted by the expression code. So now I've set it up for visitors to be able to directly visit literals and get all literals

bors · 2025-02-03T12:00:17Z

⌛ Trying commit 663191d with merge 812f026...

bors · 2025-02-03T13:51:15Z

☀️ Try build successful - checks-actions
Build commit: 812f026 (812f0268ec8fd8cf08b806b6e5343daa579f124e)

rust-timer · 2025-02-03T15:09:04Z

Finished benchmarking commit (812f026): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.9%, -1.6%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.9%, -1.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.014s -> 777.526s (-0.19%)
Artifact size: 328.74 MiB -> 328.77 MiB (0.01%)

oli-obk · 2025-02-05T09:59:13Z

@bors rollup-
@bors r=compiler-errors

bors · 2025-02-05T09:59:16Z

📌 Commit 663191d has been approved by compiler-errors

It is now in the queue for this repository.

…ks, r=compiler-errors Fix accidentally not emitting overflowing literals lints anymore in patterns This was regressed in rust-lang#134228 (not in beta yet). The issue was that previously we nested `hir::Expr` inside `hir::PatKind::Lit`, so it was linted by the expression code. So now I've set it up for visitors to be able to directly visit literals and get all literals

jieyouxu · 2025-02-05T11:08:11Z

tests/ui/pattern/overflowing-literals.rs

+type TooBig = pattern_type!(u8 is 500..);
+type TooSmall = pattern_type!(i8 is -500..);


Looks like these now also emit error messages

jieyouxu · 2025-02-05T11:08:57Z

Failed in #136570 (comment):

1 error: literal out of range for `u8`
+   --> $DIR/overflowing-literals.rs:9:35
+    |
+ LL | type TooBig = pattern_type!(u8 is 500..);
+    |
+    |
+    = note: the literal `500` does not fit into the type `u8` whose range is `0..=255`
+    = note: `#[deny(overflowing_literals)]` on by default
[... and more]

@bors r-

…its Span

oli-obk · 2025-02-05T11:28:57Z

@bors r=compiler-errors

bors · 2025-02-05T11:29:00Z

📌 Commit 9a2073d has been approved by compiler-errors

It is now in the queue for this repository.

…ks, r=compiler-errors Fix accidentally not emitting overflowing literals lints anymore in patterns This was regressed in rust-lang#134228 (not in beta yet). The issue was that previously we nested `hir::Expr` inside `hir::PatKind::Lit`, so it was linted by the expression code. So now I've set it up for visitors to be able to directly visit literals and get all literals

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136530 (Implement `x perf` directly in bootstrap) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136589 (Enable "jump to def" feature on rustc docs) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136435 (Simplify some code for lowering THIR patterns) - rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 7 pull requests Successful merges: - rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136435 (Simplify some code for lowering THIR patterns) - rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-gnu-debug

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#136073 (Always compute coroutine layout for eagerly emitting recursive layout errors) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136435 (Simplify some code for lowering THIR patterns) - rust-lang#136630 (Change two std process tests to not output to std{out,err}, and fix test suite stat reset in bootstrap CI test rendering) r? `@ghost` `@rustbot` modify labels: rollup try-job: aarch64-gnu-debug

…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#135439 (Make `-O` mean `OptLevel::Aggressive`) - rust-lang#136193 (Implement pattern type ffi checks) - rust-lang#136235 (Pretty print pattern type values with transmute if they don't satisfy their pattern) - rust-lang#136311 (Ensure that we never try to monomorphize the upcasting or vtable calls of impossible dyn types) - rust-lang#136315 (Use short ty string for binop and unop errors) - rust-lang#136393 (Fix accidentally not emitting overflowing literals lints anymore in patterns) - rust-lang#136530 (Implement `x perf` directly in bootstrap) - rust-lang#136580 (Couple of changes to run rustc in miri) - rust-lang#136589 (Enable "jump to def" feature on rustc docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#136393 - oli-obk:pattern-type-lit-oflo-checks, r=compiler-errors Fix accidentally not emitting overflowing literals lints anymore in patterns This was regressed in rust-lang#134228 (not in beta yet). The issue was that previously we nested `hir::Expr` inside `hir::PatKind::Lit`, so it was linted by the expression code. So now I've set it up for visitors to be able to directly visit literals and get all literals

rustbot assigned chenyukang Feb 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2025

This comment has been minimized.

Sign in to view

lqd reviewed Feb 1, 2025

View reviewed changes

tests/ui/type/pattern_types/overflowing_literals_in_patterns.rs Outdated Show resolved Hide resolved

oli-obk force-pushed the pattern-type-lit-oflo-checks branch 2 times, most recently from 60f4875 to 663191d Compare February 1, 2025 22:16

compiler-errors approved these changes Feb 2, 2025

View reviewed changes

rustbot assigned compiler-errors and unassigned chenyukang Feb 2, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 2, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 3, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 3, 2025

jieyouxu mentioned this pull request Feb 5, 2025

Rollup of 12 pull requests #136569

Closed

jieyouxu mentioned this pull request Feb 5, 2025

Rollup of 11 pull requests #136570

Closed

jieyouxu reviewed Feb 5, 2025

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2025

jieyouxu closed this Feb 5, 2025

jieyouxu reopened this Feb 5, 2025

oli-obk added 3 commits February 5, 2025 11:25

Add regression test

d1231ea

Avoid passing around an Expr that is only needed for its HirId and …

9f5473f

…its Span

Uniformly handle HIR literals in visitors and lints

9a2073d

oli-obk force-pushed the pattern-type-lit-oflo-checks branch from 663191d to 9a2073d Compare February 5, 2025 11:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2025

workingjubilee mentioned this pull request Feb 6, 2025

Rollup of 9 pull requests #136614

Closed

matthiaskrgr mentioned this pull request Feb 6, 2025

Rollup of 7 pull requests #136641

Merged

bors merged commit 85a9de5 into rust-lang:master Feb 6, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Feb 6, 2025

matthiaskrgr mentioned this pull request Feb 7, 2025

ICE: None in type limit lint(?) #136675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix accidentally not emitting overflowing literals lints anymore in patterns #136393

Fix accidentally not emitting overflowing literals lints anymore in patterns #136393

oli-obk commented Feb 1, 2025 •

edited

Loading

rustbot commented Feb 1, 2025

This comment has been minimized.

rustbot commented Feb 1, 2025

compiler-errors commented Feb 2, 2025

bors commented Feb 2, 2025

oli-obk commented Feb 3, 2025

oli-obk commented Feb 3, 2025

This comment has been minimized.

bors commented Feb 3, 2025

bors commented Feb 3, 2025

This comment has been minimized.

rust-timer commented Feb 3, 2025

oli-obk commented Feb 5, 2025

bors commented Feb 5, 2025

jieyouxu Feb 5, 2025

jieyouxu commented Feb 5, 2025

oli-obk commented Feb 5, 2025

bors commented Feb 5, 2025

		type TooBig = pattern_type!(u8 is 500..);
		type TooSmall = pattern_type!(i8 is -500..);

Fix accidentally not emitting overflowing literals lints anymore in patterns #136393

Fix accidentally not emitting overflowing literals lints anymore in patterns #136393

Conversation

oli-obk commented Feb 1, 2025 • edited Loading

rustbot commented Feb 1, 2025

This comment has been minimized.

rustbot commented Feb 1, 2025

compiler-errors commented Feb 2, 2025

bors commented Feb 2, 2025

oli-obk commented Feb 3, 2025

oli-obk commented Feb 3, 2025

This comment has been minimized.

bors commented Feb 3, 2025

bors commented Feb 3, 2025

This comment has been minimized.

rust-timer commented Feb 3, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

oli-obk commented Feb 5, 2025

bors commented Feb 5, 2025

jieyouxu Feb 5, 2025

Choose a reason for hiding this comment

jieyouxu commented Feb 5, 2025

oli-obk commented Feb 5, 2025

bors commented Feb 5, 2025

oli-obk commented Feb 1, 2025 •

edited

Loading