-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject negative literals for unsigned or char types in pattern ranges and literals #136304
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
#![feature(pattern_types)] | ||
#![feature(pattern_type_macro)] | ||
|
||
use std::pat::pattern_type; | ||
|
||
type Sign = pattern_type!(u32 is -10..); | ||
//~^ ERROR: cannot apply unary operator `-` | ||
|
||
type SignedChar = pattern_type!(char is -'A'..); | ||
//~^ ERROR: cannot apply unary operator `-` | ||
|
||
fn main() { | ||
match 42_u8 { | ||
-10..253 => {} | ||
//~^ ERROR `u8: Neg` is not satisfied | ||
_ => {} | ||
} | ||
|
||
match 'A' { | ||
-'\0'..'a' => {} | ||
//~^ ERROR `char: Neg` is not satisfied | ||
_ => {} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
error[E0277]: the trait bound `u8: Neg` is not satisfied | ||
--> $DIR/signed_ranges.rs:14:9 | ||
| | ||
LL | -10..253 => {} | ||
| ^^^ the trait `Neg` is not implemented for `u8` | ||
| | ||
= help: the following other types implement trait `Neg`: | ||
&f128 | ||
&f16 | ||
&f32 | ||
&f64 | ||
&i128 | ||
&i16 | ||
&i32 | ||
&i64 | ||
and 12 others | ||
|
||
error[E0277]: the trait bound `char: Neg` is not satisfied | ||
--> $DIR/signed_ranges.rs:20:9 | ||
| | ||
LL | -'\0'..'a' => {} | ||
| ^^^^^ the trait `Neg` is not implemented for `char` | ||
|
||
error[E0600]: cannot apply unary operator `-` to type `u32` | ||
--> $DIR/signed_ranges.rs:6:34 | ||
| | ||
LL | type Sign = pattern_type!(u32 is -10..); | ||
| ^^^ cannot apply unary operator `-` | ||
| | ||
= note: unsigned values cannot be negated | ||
|
||
error[E0600]: cannot apply unary operator `-` to type `char` | ||
--> $DIR/signed_ranges.rs:9:41 | ||
| | ||
LL | type SignedChar = pattern_type!(char is -'A'..); | ||
| ^^^^ cannot apply unary operator `-` | ||
|
||
error: aborting due to 4 previous errors | ||
|
||
Some errors have detailed explanations: E0277, E0600. | ||
For more information about an error, try `rustc --explain E0277`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried improving this error by having it point to where we got the
u8
type information from (the scrutinee), but adding the right obligations for that didn't work out, so I'll need to do some more debugging.But this is also the exact same diagnostic we get on stable and beta, so...