Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler_fence: fix example #136079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiler_fence: fix example #136079

wants to merge 1 commit into from
+13 −13

Conversation

RalfJung
Copy link
Member

The old example was wrong, an acquire fence is required in the signal handler. To make the point more clear, I changed the "data" variable to use non-atomic accesses.

Fixes #133014

@rustbot
Copy link
Collaborator

rustbot commented Jan 26, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 26, 2025
@RalfJung RalfJung mentioned this pull request Jan 26, 2025
Open
jhpratt
jhpratt reviewed Jan 26, 2025
View reviewed changes
library/core/src/sync/atomic.rs Outdated Show resolved Hide resolved
library/core/src/sync/atomic.rs Outdated Show resolved Hide resolved
library/core/src/sync/atomic.rs Show resolved Hide resolved
@RalfJung RalfJung force-pushed the compiler-fence-example branch from 58afc6b to 9c972c0 Compare January 27, 2025 00:34
@jhpratt
Copy link
Member

jhpratt commented Jan 27, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 27, 2025

📌 Commit 9c972c0 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
fmease added a commit to fmease/rust that referenced this pull request Jan 27, 2025
@fmease
Rollup merge of rust-lang#136079 - RalfJung:compiler-fence-example, r…
bd2f6d7 
…=jhpratt

compiler_fence: fix example

The old example was wrong, an acquire fence is required in the signal handler. To make the point more clear, I changed the "data" variable to use non-atomic accesses.

Fixes rust-lang#133014
@fmease fmease mentioned this pull request Jan 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpratt jhpratt jhpratt left review comments

Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler_fence example is misleading
4 participants
@RalfJung @rustbot @jhpratt @bors