fix tail call checks wrt #[track_caller]
#135973
Open
+92
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
6 tasks
This comment has been minimized.
This comment has been minimized.
WaffleLapkin
force-pushed
the
tail-track-caller-fix
branch
from
032f4e7 to
d746614
Compare
This comment has been minimized.
This comment has been minimized.
only check the caller + disallow caller having the attr.
WaffleLapkin
force-pushed
the
tail-track-caller-fix
branch
from
d746614 to
e4229ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check the caller + disallow caller having the attribute.
fixes #134336
r? @compiler-errors
apparently there were no tests for
#[track_caller]before... ooops