Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expand/collapse all on site, make highlightjs lazier #14038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Jan 20, 2025

This fixes the buttons that expand/collapse all the lints in the list, it also makes code block syntax highlighting only happen when the specific lint enters the viewport since highlighting them all at once was fairly heavy

There's also a few miscellaneous inline event handler removals

script.js and highlightjs are now loaded with defer so that the download can start earlier

Also fixes #14048, we were calling highlight on the pre in <pre><code>...</code></pre> but highlightjs wants us to call it on the code element

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 20, 2025
@Alexendoo Alexendoo force-pushed the site-expand-collapse branch from 84dcb9a to bb746e1 Compare January 22, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code highlighting on lints website using SCSS language a lot somehow?
3 participants