Skip to content

PidController tests time out #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christophfroehlich opened this issue Mar 25, 2025 · 1 comment
Open

PidController tests time out #1608

christophfroehlich opened this issue Mar 25, 2025 · 1 comment
Labels
bug CI

Comments

@christophfroehlich
Copy link
Contributor

Regularily, the PID tests hit the timeout in the CI

2025-03-25T02:46:50.5533401Z     Start 1: test_pid_controller
2025-03-25T02:46:50.5533545Z 
2025-03-25T02:46:50.5536648Z 1: Test command: /usr/bin/python3 "-u" "/opt/ros/jazzy/share/ament_cmake_test/cmake/run_test.py" "/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_results/pid_controller/test_pid_controller.gtest.xml" "--package-name" "pid_controller" "--output-file" "/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_results/pid_controller/test_pid_controller.txt" "--command" "/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_pid_controller" "--ros-args" "--params-file" "/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/src/ros2_controllers/pid_controller/test/pid_controller_params.yaml" "--" "--gtest_output=xml:/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_results/pid_controller/test_pid_controller.gtest.xml"
2025-03-25T02:46:50.5540482Z 1: Working Directory: /home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller
2025-03-25T02:46:50.5540948Z 1: Test timeout computed to be: 60
2025-03-25T02:46:50.5541552Z 1: -- run_test.py: invoking following command in '/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller':
2025-03-25T02:46:50.5543573Z 1:  - /home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_pid_controller --ros-args --params-file /home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/src/ros2_controllers/pid_controller/test/pid_controller_params.yaml -- --gtest_output=xml:/home/runner/work/ros2_controllers/ros2_controllers/.work/target_ws/build/pid_controller/test_results/pid_controller/test_pid_controller.gtest.xml
2025-03-25T02:46:50.5545321Z 1: [==========] Running 18 tests from 1 test suite.
2025-03-25T02:46:50.5545698Z 1: [----------] Global test environment set-up.
2025-03-25T02:46:50.5546089Z 1: [----------] 18 tests from PidControllerTest
2025-03-25T02:46:50.5546415Z 1: [ RUN      ] PidControllerTest.all_parameters_set_configure_success
2025-03-25T02:46:50.5546904Z 1: [INFO] [1742870749.936259448] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5547317Z 1: [       OK ] PidControllerTest.all_parameters_set_configure_success (35 ms)
2025-03-25T02:46:50.5547862Z 1: [ RUN      ] PidControllerTest.check_exported_interfaces
2025-03-25T02:46:50.5548227Z 1: [INFO] [1742870749.953699609] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5548760Z 1: [       OK ] PidControllerTest.check_exported_interfaces (15 ms)
2025-03-25T02:46:50.5549291Z 1: [ RUN      ] PidControllerTest.activate_success
2025-03-25T02:46:50.5549638Z 1: [INFO] [1742870749.970365225] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5550089Z 1: [       OK ] PidControllerTest.activate_success (16 ms)
2025-03-25T02:46:50.5550381Z 1: [ RUN      ] PidControllerTest.update_success
2025-03-25T02:46:50.5550768Z 1: [INFO] [1742870749.987271453] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5551165Z 1: [       OK ] PidControllerTest.update_success (17 ms)
2025-03-25T02:46:50.5551470Z 1: [ RUN      ] PidControllerTest.deactivate_success
2025-03-25T02:46:50.5551893Z 1: [INFO] [1742870750.004503473] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5552250Z 1: [       OK ] PidControllerTest.deactivate_success (17 ms)
2025-03-25T02:46:50.5552651Z 1: [ RUN      ] PidControllerTest.reactivate_success
2025-03-25T02:46:50.5552985Z 1: [INFO] [1742870750.021467489] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5553430Z 1: [       OK ] PidControllerTest.reactivate_success (16 ms)
2025-03-25T02:46:50.5553754Z 1: [ RUN      ] PidControllerTest.test_feedforward_mode_service
2025-03-25T02:46:50.5554319Z 1: [INFO] [1742870750.037944120] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5554730Z 1: [       OK ] PidControllerTest.test_feedforward_mode_service (16 ms)
2025-03-25T02:46:50.5555164Z 1: [ RUN      ] PidControllerTest.test_update_logic_feedforward_off
2025-03-25T02:46:50.5555571Z 1: [INFO] [1742870750.053647698] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5556013Z 1: [       OK ] PidControllerTest.test_update_logic_feedforward_off (15 ms)
2025-03-25T02:46:50.5556558Z 1: [ RUN      ] PidControllerTest.test_update_logic_feedforward_on_with_zero_feedforward_gain
2025-03-25T02:46:50.5557113Z 1: [INFO] [1742870750.070370304] [test_pid_controller]: configure successful
2025-03-25T02:46:50.5557582Z 1/4 Test #1: test_pid_controller ..................***Timeout  60.00 sec
This was referenced Mar 25, 2025
Closed
Closed
@christophfroehlich
Copy link
Contributor Author

#1649

@christophfroehlich christophfroehlich changed the title test_update_logic_feedforward_on_with_zero_feedforward_gain times out PidController tests time out Apr 21, 2025
@christophfroehlich christophfroehlich mentioned this issue Apr 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christophfroehlich