Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ListObjectsV2 #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement ListObjectsV2 #23

wants to merge 4 commits into from

Conversation

frank-horus
Copy link

Hi,

I've implemented ListObjectsV2.

Please let me know if I need to change anything.

rhnvrm
rhnvrm requested changes May 16, 2022
View reviewed changes
Copy link
Owner

@rhnvrm rhnvrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I have suggested a few changes.

Also, would it be possible to make the changes to the README as well in this PR itself?

simples3.go Show resolved Hide resolved
simples3.go Outdated Show resolved Hide resolved
simples3.go Show resolved Hide resolved
simples3.go
MaxKeys string `xml:"MaxKeys"`
Delimiter string `xml:"Delimiter"`
IsTruncated string `xml:"IsTruncated"`
Contents []struct {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be extracted into a named struct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure. What's your preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhnvrm rhnvrm rhnvrm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frank-horus @rhnvrm