Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mechanical] Upgrade prost-dto to 0.0.3 #2477

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[Mechanical] Upgrade prost-dto to 0.0.3 #2477

merged 1 commit into from
Jan 9, 2025

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jan 8, 2025

prost-dto 0.0.3 renames IntoProto/FromProto to IntoProst/FromProst and all macro attributes accordingly. It also removes the auto skipping of fields, only fields marked with #[prost(skip)] are now skipped.

prost-dto 0.0.3 renames IntoProto/FromProto to `IntoProst/FromProst` and all macro attributes accordingly. It also removes the auto skipping of fields, only fields marked with `#[prost(skip)]` are now skipped.
@AhmedSoliman AhmedSoliman changed the title Upgrade prost-dto to 0.0.3 [Mechanical] Upgrade prost-dto to 0.0.3 Jan 8, 2025
@AhmedSoliman AhmedSoliman marked this pull request as ready for review January 8, 2025 22:27
Copy link

github-actions bot commented Jan 8, 2025

Test Results

  5 files   -  2    5 suites   - 2   2m 4s ⏱️ - 2m 12s
 45 tests  -  2   45 ✅  -  1  0 💤  - 1  0 ❌ ±0 
114 runs   - 68  114 ✅  - 65  0 💤  - 3  0 ❌ ±0 

Results for commit 85c8fb3. ± Comparison against base commit 22fcef1.

This pull request removes 2 tests.
dev.restate.sdktesting.tests.AwaitTimeout ‑ timeout(Client)
dev.restate.sdktesting.tests.RawHandler ‑ rawHandler(Client)

♻️ This comment has been updated with latest results.

@AhmedSoliman
Copy link
Contributor Author

A mechanical change, adding @tillrohrmann as reviewer primarily for visibility.

@AhmedSoliman AhmedSoliman merged commit 558f2dd into main Jan 9, 2025
29 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2477 branch January 9, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant