Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/asdf): add asdf container-structure-test, helm-docs, kubetail, skaffold, talhelper, talosctl, and terraformer support #34703

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

woneill
Copy link

@woneill woneill commented Mar 8, 2025

Changes

Add support for upgrading container-structure-test, helm-docs, kubetail, skaffold, talhelper, talosctl, and terraformer versions in .tool-versions files, as supported by https://asdf-vm.com/.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test PR: woneill/renovate-testing#1

datasource: 'github-releases',
packageName: 'johanhaleby/kubetail',
depName: 'kubetail',
extractVersion: '^(?<version>\\S+)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extractVersion: '^(?<version>\\S+)',

No need in these cases

},
{
currentValue: '1.9.3',
datasource: 'github-tags',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tags and not releases?

datasource: 'github-releases',
packageName: 'GoogleCloudPlatform/terraformer',
depName: 'terraformer',
extractVersion: '^(?<version>\\S+)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extractVersion: '^(?<version>\\S+)',

Unnecessary

config: {
datasource: GithubReleasesDatasource.id,
packageName: 'johanhaleby/kubetail',
extractVersion: '^(?<version>\\S+)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extractVersion: '^(?<version>\\S+)',

config: {
datasource: GithubReleasesDatasource.id,
packageName: 'GoogleCloudPlatform/terraformer',
extractVersion: '^(?<version>\\S+)',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extractVersion: '^(?<version>\\S+)',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants