-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interative reconfigure pr #34696
base: main
Are you sure you want to change the base?
Conversation
remaining - pr - comment - refactoring - validation of cache purity - tests - reconfigureCache setting and deletion
const existingPr = await platform.findPr({ | ||
branchName: reconfigureBranch, | ||
state: 'open', | ||
includeOtherAuthors: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't work on gotta and other platforms because we only have our own PRs cached
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add this support to other platforms as per user requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be done in a way to not fetch all PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except Gitea all other platforms has these feature implemented and in a way they fetch only that one PR.
I will try to look into how to get it done for Gitea. Would be great also to cache it in the repoCache.
Changes
mergeRenovateConfig
fn such that it can pass the branchName to thedetectConfigFile
fn which comes in handy when trying to read the config file from reconfigure branch using api endpointContext
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: