Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interative reconfigure pr #34696

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • check if reconfigure pr exists
  • if reconfigure pr found, add a comment on the pr with expected pr's list and config description
  • expand reconfigure cache to store extraction result so we can skip processing the reconfigure branch if it has not changed
  • make slight changes mergeRenovateConfig fn such that it can pass the branchName to the detectConfigFile fn which comes in handy when trying to read the config file from reconfigure branch using api endpoint
  • added tests

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required (todo)

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository 1. reconf pr Rahul-renovate-testing/recon-pr#1 (will be adding more...)

@RahulGautamSingh RahulGautamSingh marked this pull request as draft March 8, 2025 05:54
const existingPr = await platform.findPr({
branchName: reconfigureBranch,
state: 'open',
includeOtherAuthors: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work on gotta and other platforms because we only have our own PRs cached

Copy link
Collaborator Author

@RahulGautamSingh RahulGautamSingh Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this support to other platforms as per user requests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be done in a way to not fetch all PRs

Copy link
Collaborator Author

@RahulGautamSingh RahulGautamSingh Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except Gitea all other platforms has these feature implemented and in a way they fetch only that one PR.

I will try to look into how to get it done for Gitea. Would be great also to cache it in the repoCache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive Reconfigure PR
2 participants