feat(git): use git fetching for fork mode (revived) #34467
Draft
+35
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@rarkins Please review and see if the intent of your original PR is preserved here. There could of course be other places in the code base that need touching due to codebase changes. There may be a need for additional tests. Please guide/advice. |
janhoy
commented
Feb 25, 2025
| config.branchCommits = {}; | ||
| const opts = ['ls-remote', '--heads', config.url]; | ||
| const url = | ||
| preferUpstream && config.upstreamUrl ? config.upstreamUrl : config.url; |
There was a problem hiding this comment.
Coverage test fails on this line. Need to trigger syncGit() with preferUpstream==false in some test..
Revival of renovatebot#13808 Signed-off-by: Jan Høydahl <[email protected]>
janhoy
force-pushed
the
feat/fork-with-git
branch
from
e1d615f to
2ad36c3
Compare
6 tasks
rarkins
requested changes
Mar 2, 2025
| (await getDefaultBranch(git)); | ||
| delete getCache()?.semanticCommits; | ||
| config.currentBranch = config.currentBranch || (await getDefaultBranch(git)); | ||
| // istanbul ignore if |
There was a problem hiding this comment.
Suggested change
| // istanbul ignore if |
Let's aim to test it this time
Signed-off-by: Jan Høydahl <[email protected]>
|
Marking this as a draft. I'm tempted to focus the energy on #34532 which is currently being updated after reviews, and which builds on this PR and extends/refactors it, and enables baseBranches for forks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #13586.
Changes
Apply code from 3-year old PR #13808 to current main branch.
Context
We need to use renovate in forking mode on two different branches. So I was recommended in #7850 (comment) to revive an old PR to get a starting point.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: