fix(lockfilemaintenance): ensure isLockFileMaintenance on grouping
#33971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rarkins
reviewed
Feb 1, 2025
| const isLockFileMaintenance = config.updateType === 'lockFileMaintenance'; | ||
| const { isLockFileMaintenance } = config; |
There was a problem hiding this comment.
When I see old code which references config.updateType, it implies to me that config just be an "update" config and not a "branch" config.
| if (config.upgrades.some((upgrade) => upgrade.updateType === 'major')) { | ||
| config.updateType = 'major'; | ||
| } | ||
|
|
||
| // explicit set `isLockFileMaintenance` for the branch for groups | ||
| if (config.upgrades.some((upgrade) => upgrade.isLockFileMaintenance)) { |
There was a problem hiding this comment.
Here, config = branch config. So you're setting branchConfig.isLockFileMaintenance=true if any update in the branch has isLockFileMaintenance set. This seems logically correct. But I think updateArtifacts() is no called on a full branch, so the refactorings within manager code seem unrelated or mismatched with this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ensure
isLockFileMaintenanceistrueif grouping lockefile maintenance with other updates even it's not really supported.Context
lockFileMaintenancenot working #32384Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: